MOBILE-413:Measure the content the block shows, whatever the host does - #760
Open
sergeysozinov wants to merge 2 commits into
Open
MOBILE-413:Measure the content the block shows, whatever the host does#760sergeysozinov wants to merge 2 commits into
sergeysozinov wants to merge 2 commits into
Conversation
sergeysozinov
requested review from
enotniy
and
a balanced review from Copilot
September 1, 2026 14:34
There was a problem hiding this comment.
🟡 Changes recommended
Dynamic padding changes can leave content using stale bounds when the host suppresses layout.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Ensures embedded content is measured and positioned even when its host suppresses layout passes.
Changes:
- Adds direct content measurement and placement.
- Adds Robolectric coverage for delayed content and placeholders.
File summaries
| File | Description |
|---|---|
MindboxEmbeddedBlockView.kt |
Adds host-independent content layout. |
MindboxEmbeddedBlockViewContentLayoutTest.kt |
Tests layout edge cases. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.yandex.ru/MOBILE-413